test: improve test coverage for WHATWG TextDecoder
#45241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
targos
approved these changes
Oct 30, 2022
targos
reviewed
Oct 30, 2022
juanarbol
force-pushed
the
juan/coverage-text-decoder
branch
from
f6fe293 to
9da7a2d
Compare
aduh95
reviewed
Oct 30, 2022
RaisinTen
approved these changes
Oct 31, 2022
lpinca
approved these changes
Nov 1, 2022
Signed-off-by: Juan José Arboleda <[email protected]>
juanarbol
force-pushed
the
juan/coverage-text-decoder
branch
from
9da7a2d to
279a24b
Compare
github-actions
bot
removed
the
request-ci
juanarbol
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/45241 ✔ Done loading data for nodejs/node/pull/45241 ----------------------------------- PR info ------------------------------------ Title test: improve test coverage for WHATWG `TextDecoder` (#45241) Author Juan José (@juanarbol) Branch juanarbol:juan/coverage-text-decoder -> nodejs:main Labels test, needs-ci Commits 1 - test: improve test coverage for WHATWG `TextDecoder` Committers 1 - Juan José Arboleda PR-URL: https://github.com/nodejs/node/pull/45241 Reviewed-By: Michaël Zasso Reviewed-By: Darshan Sen Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45241 Reviewed-By: Michaël Zasso Reviewed-By: Darshan Sen Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - test: improve test coverage for WHATWG `TextDecoder` ℹ This PR was created on Sun, 30 Oct 2022 05:29:47 GMT ✔ Approvals: 3 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/45241#pullrequestreview-1161065185 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/45241#pullrequestreview-1161328552 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45241#pullrequestreview-1163985761 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-11-08T19:24:23Z: https://ci.nodejs.org/job/node-test-pull-request/47793/ - Querying data for job/node-test-pull-request/47793/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3431474431 |
|
Is this ok to land? It looks like |
anonrig
approved these changes
Nov 14, 2022
jasnell
approved these changes
Nov 16, 2022
lpinca
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5d56097 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
Signed-off-by: Juan José Arboleda <[email protected]> PR-URL: #45241 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
juanarbol
added a commit
that referenced
this pull request
Jan 26, 2023
Signed-off-by: Juan José Arboleda <[email protected]> PR-URL: #45241 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
juanarbol
added a commit
that referenced
this pull request
Jan 31, 2023
Signed-off-by: Juan José Arboleda <[email protected]> PR-URL: #45241 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan José Arboleda [email protected]